feat: bump viem to 1.6.0 #1308
Merged
feat: bump viem to 1.6.0 #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db79b4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
reviewed
Aug 15, 2023
| return /already known|nonce too low/.test(String(error)); | ||
| return ( | ||
| error instanceof BaseError && | ||
| error.walk((e) => e instanceof NonceTooLowError || e instanceof NonceTooHighError) != null |
There was a problem hiding this comment.
for context, when is a NonceTooHighError triggered? Shouldn't it be possible to submit nonces with gaps / would viem error in that case?
There was a problem hiding this comment.
honestly not sure how to trigger this, but I assume it's in viem because it's in the geth source: https://github.com/search?q=repo%3Aethereum%2Fgo-ethereum+ErrNonceTooHigh&type=code
and seemed like a good case to re-fetch the current nonce from the chain before retrying
alvrs
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1276
fixes #1262